add a test case for issue #32031 #34241
Conversation
|
@dsprenkels Can you add the email address you used in the commit to your github account? Otherwise the commits are not linked to your account. This is of course not necessary, let me know if it's intentional. |
| #[no_mangle] | ||
| pub struct F32(f32); | ||
|
|
||
| // CHECK: @add_newtype_f32(float, float) |
There was a problem hiding this comment.
Any chance this could also check the return type?
There was a problem hiding this comment.
What I meant, btw, is that the full signature is define float @add_newtype_f32(float, float) - and if you include all of it, you also ensure the return type is correct.
There was a problem hiding this comment.
Oh, check. I'll fix this accordingly.
dsprenkels
force-pushed
the
issue-32031-test
branch
from
5645c76 to
5f49e85
Compare
|
Yup, this was indeed not intentional. Thanks for the heads-up! I also added a check for the return type. |
dsprenkels
force-pushed
the
issue-32031-test
branch
from
5f49e85 to
a30130d
Compare
| pub struct F64(f64); | ||
|
|
||
| // CHECK: @add_newtype_f64(double, double) | ||
| // CHECK: ret float |
dsprenkels
force-pushed
the
issue-32031-test
branch
from
a30130d to
e196021
Compare
dsprenkels
force-pushed
the
issue-32031-test
branch
from
e196021 to
688840f
Compare
|
@bors r+ Thanks! |
|
📌 Commit 688840f has been approved by |
I propose a test case to finish the fix for issue #32031. Please review this commit thoroughly, as I have never written a codegen test before.
r? @eddyb